Skip to content

♻️ Fix regex pattern for Domain #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Conversation

rosscdh-tpg
Copy link
Contributor

AS discussed in 307, issues with domain regexp allowed ip address and cidr

  • updated regexp
  • added tests for ip and cidr
  • moved pattern to be a class var that can be overridden on deman

@yezz123 yezz123 linked an issue Apr 7, 2025 that may be closed by this pull request
Copy link
Collaborator

@yezz123 yezz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@yezz123 yezz123 changed the title fix: 307 class variable for pattern and updated regexp added tests ♻️ Fix regex pattern for Domain Apr 7, 2025
@yezz123 yezz123 merged commit 35102a4 into pydantic:main Apr 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DomainStr allows ip addresses
2 participants